Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update CHANGELOG.md for v10 #2500

Merged
merged 2 commits into from
May 18, 2023
Merged

docs: Update CHANGELOG.md for v10 #2500

merged 2 commits into from
May 18, 2023

Conversation

shaspitz
Copy link
Contributor

@shaspitz shaspitz commented May 17, 2023 •
edited
Loading

Description

Updates changelog

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API or client breaking change
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@shaspitz shaspitz changed the title Update CHANGELOG.md for v10 docs: Update CHANGELOG.md for v10 May 17, 2023
shaspitz
shaspitz commented May 18, 2023
View reviewed changes
MSalopek
MSalopek approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaspitz shaspitz marked this pull request as ready for review May 18, 2023 18:54
jtremback
jtremback approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@jtremback jtremback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaspitz shaspitz merged commit d5a019c into main May 18, 2023
@shaspitz shaspitz deleted the update-changelog-v10 branch May 18, 2023 20:45
mergify bot pushed a commit that referenced this pull request May 18, 2023
@shaspitz @mergify
docs: Update CHANGELOG.md for v10 (#2500)
3f15274 
* Update CHANGELOG.md

* Update CHANGELOG.md

(cherry picked from commit d5a019c)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request May 18, 2023
Merged
shaspitz added a commit that referenced this pull request May 18, 2023
@mergify @shaspitz
docs: Update CHANGELOG.md for v10 (backport #2500) (#2504)
6c4d7f1 
* docs: Update CHANGELOG.md for v10 (#2500)

* Update CHANGELOG.md

* Update CHANGELOG.md

(cherry picked from commit d5a019c)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Shawn <44221603+smarshall-spitzbart@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtremback jtremback jtremback approved these changes

@MSalopek MSalopek MSalopek approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@yaruwangway yaruwangway Awaiting requested review from yaruwangway

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@mmulji-ic mmulji-ic Awaiting requested review from mmulji-ic

@glnro glnro Awaiting requested review from glnro

@mpoke mpoke Awaiting requested review from mpoke

@sainoe sainoe Awaiting requested review from sainoe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaspitz @jtremback @MSalopek